Skip to content

fix: show fallback title on seekbar tooltip if segment title is missing #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Harsheetsharma
Copy link

Description

This PR fixes the issue where the seekbar tooltip was only showing the timestamp (e.g., 0:04) but missing the title for some courses like "Web3".

Root Cause

In VideoPlayerSegment.tsx, the tooltip text was built using:

this.write(`${time} - ${segmentName}`);

and I have added 
this.write(segmentName? `${time} - ${segmentName}`:`${time}`);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant