[pull] next from storybookjs:next#823
Merged
Merged
Conversation
…elog CI: Add missing changelog entry following CI failure
…5.0-alpha.5 Release: Prerelease 10.5.0-alpha.6
…g-sandbox Build: Rewrite config overrides in SvelteKit sandbox
Fix formatting
findFirstPath returns a path relative to the sandbox cwd, but getConfigFile passed it straight to readConfig, which resolved it against the script's own working directory. This broke the svelte and sveltekit create jobs on next with 'ENOENT: open svelte.config.js' / 'vite.config.ts' since #35127.
…config-path Build: Resolve svelte config paths against the sandbox cwd in sandbox-parts
…e array The resolve/server injection matched the whole plugins array with [^\]]*, which cuts short at the first ']' — and the sveltekit template's runes regex /[/\\]/ contains one, so the injection landed inside the regex literal and produced an unparseable vite.config.ts (the build/dev failures on #35130). Injecting the siblings before the plugins key never touches the array contents.
…gins-injection Build: Anchor vite config injection on the plugins key in sandbox-parts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )