[pull] canary from vercel:canary#320
Merged
Merged
Conversation
Fixes edge runtime pages with dynamic routes returning 500 errors when the URL segment literally contains bracket syntax that matches the folder name (e.g., accessing `/[id]` for a route defined as `/[id]/page.tsx`). The removal of web-server.ts in #81389 modified how route params were extracted for dynamic routes. The route matcher in prepare() was being created with the full internal page path (e.g., /[id]/page) which generated a regex expecting /page at the end. However, actual URL pathnames don't include the /page suffix, causing the matcher to fail when trying to extract params. This issue specifically manifested when the URL contained literal brackets (like /[id]), as the fallback param extraction would fail and leave params empty, leading to the error. This PR normalizes the page path using before creating the route matcher in prepare(). This ensures the regex pattern matches the actual URL pathname format (without /page suffix). Fixes NEXT-4698
Writing to `join(next.testDir, '../package-lock.json')` breaks test isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )