[pull] main from fern-api:main#785
Merged
Merged
Conversation
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: tanmay.singh <tstanmay13@gmail.com>
…ints (#16454) feat(csharp): raw-response wrappers for streaming and void endpoints - Streaming endpoints return WithRawResponseStream<T> (IAsyncEnumerable<T> + .WithRawResponse()) - Void endpoints return non-generic WithRawResponseTask (.WithRawResponse() → Task<RawResponse>) - Fix pre-existing JSON streaming bug where parsed result was never yielded
…edException on retry (#16459) * fix(csharp): always clone request before send to prevent ObjectDisposedException on retry Restructure RawClient.SendWithRetriesAsync so the retryable-content path always sends a clone, never the original HttpRequestMessage. Under HTTP/2, HttpClient disposes request.Content after sending, which broke CloneRequestAsync on retry. Also: clamp negative MaxRetries to 0; short-circuit MaxRetries=0 and non-retryable content through a no-clone fast path; thread CancellationToken into CloneRequestAsync's body buffering. * fix(csharp): rename outer response variable to avoid CS0136 in SendWithRetriesAsync The fast-path block declares `var response` inside the `if (!isRetryableContent || maxRetries == 0)` branch; the retry loop declared `HttpResponseMessage? response = null` in the enclosing method body. C# treats the entire method as one declaration space, so the two `response` locals collide with CS0136 even though their scopes don't overlap. Rename the outer one to `retryResponse`. * chore(csharp): regenerate seed snapshots for retry fix Regenerates RawClient.cs and RetriesTests.cs (plus .fern/metadata.json bumps) for all 178 csharp-sdk fixtures to pick up the SendWithRetriesAsync rewrite, the CloneRequestAsync CancellationToken plumbing, and the new ContentDisposingHandler-based regression tests. * chore(csharp): slim the explanatory comments in generated RawClient/Retries code The verbose multi-line comments in SendWithRetriesAsync and RetriesTests ship into every generated SDK and multiply across all customer repos. Reduce the load-bearing WHY to two lines in RawClient and one each in the regression tests; the rest is in the changelog and the git history.
…s.yml (#16467) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )