[pull] main from fern-api:main#763
Merged
Merged
Conversation
…ld (#16175) The sync-cli-sdk workflow was failing because: 1. src/openapi/parser.rs has #[cfg(test)] blocks with include_str! calls referencing CLI directories (bigcommerce, box, devin, etc.) that are not synced — only cli/openapi-fixture/ is. 2. Smoke test files (square_smoke.rs, sarvam_smoke.rs, etc.) reference CARGO_BIN_EXE_<binary> env vars for binaries not in the projected Cargo.toml. Both fail under `cargo build --locked --all-features --tests`. Fix: - Remove the tests/ rsync entirely — cli-sdk's own CI validates test compilation; the vendored SDK only needs library + openapi-fixture. - Drop `--tests` from the workflow's cargo build verification — this matches what users actually build and avoids the parser.rs #[cfg(test)] include_str! issue. - Clean up stale tests/ directory if present from a prior sync revision. - Simplify src/ rsync (the old excludes for tests/ and cli/ paths were relative to src/ and therefore dead). Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…g local generation (#16160) * fix(cli): fix ENOTEMPTY error when removing temp .git directory during local generation Disable git auto-gc after git init and add maxRetries/force to fs.rm in copyGeneratedFilesWithFernIgnoreInTempRepo to handle race conditions with git background processes that may still hold references to .git/objects/pack. Co-Authored-By: will.kendall@buildwithfern.com <wpk235@gmail.com> * test(cli): add comprehensive tests for ENOTEMPTY .git cleanup fix Integration tests (LocalTaskHandler.gitCleanup.test.ts): - Verify .git directory is fully removed after copyGeneratedFiles - Verify gc.auto=0 is set via loggingExeca spy (correct ordering) - Verify gc.auto=0 via direct git config check - Verify concurrent copyGeneratedFiles calls succeed without ENOTEMPTY Unit tests (LocalTaskHandler.gitCleanupUnit.test.ts): - Verify rm(.git) is called with maxRetries:3, retryDelay:100, force:true - Verify git config gc.auto 0 is invoked between init and add Co-Authored-By: will.kendall@buildwithfern.com <wpk235@gmail.com> * style: fix biome formatting in test files Co-Authored-By: will.kendall@buildwithfern.com <wpk235@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: will.kendall@buildwithfern.com <wpk235@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )