Conversation
# Why Android needs own JavaScript runtime (Hermes) equivalent to the existing iOS JSC runtime so widgets can render registered layouts with props and environment values. # How - Added a native `WidgetsHermesRuntime` backed by Hermes # Test Plan - Verified on the stack. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why This PR adds the Android components layer for Expo Widgets, it uses the `@expo/ui/jetpack-compose` js layer with custom native components from Jetpack Glance. # How Adds a basic rendering layer that maps widget layout output to Android Glance components, reusing shared Expo UI props and modifier data where possible. # Test Plan - Build an Android app using `expo-widgets`. - Verify basic widget layouts render correctly on Android. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…47019) Fixes #47016 # Why? Here's a minimal repro to test it in browser console. ``` https://github.com/expo/expo/blob/9be13fd21712607e1d6b6031c4df7b2dbc258952/packages/%40expo/dom-webview/src/DomWebView.tsx#L44 a = JSON.stringify({ font: '"Inter"' }); // https://github.com/expo/expo/blob/9be13fd21712607e1d6b6031c4df7b2dbc258952/packages/%40expo/dom-webview/ios/DomWebView.swift#L228 b = new Function('return `' + source + '`;'); // https://github.com/expo/expo/blob/9be13fd21712607e1d6b6031c4df7b2dbc258952/packages/%40expo/cli/src/start/server/middleware/DomComponentsMiddleware.ts#L122 JSON.parse(b()) // throws error ``` ## How? Add `JSON.stringify` to function returned object so it stays compatible with `JSON.parse`. ## Test Plan Tested the original user repro.
# Why To test crashes which happen before JS had time to load. # How Add config plugin which produces native crashes during init # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )