Conversation
# Why Fixes #41125 The bounds in the cropping area are incorrect, currently block from moving the crop area to parts of the image and add a black bar to the image. # How Re-create `fixCannotMoveEditingBox` logic to fix the issue and work correctly in all device orientations (previously there would also be bugs when rotating the phone during cropping etc.) Now the cropper is effectively in `fill` `contentFit`, same as Android # Test Plan Tested in BareExpo on iOS 18
…46492) # Why Currently, when props are not provided, they default to `{}`. As a result, accessing a property such as `props.count` can fail silently, making the issue harder to detect and debug. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How Handle `undefined` props explicitly and display a redbox instead of falling back to an empty object. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
…46483) # Why Fixes - #46444 On iOS, the `TextField` / `SecureField` (and universal `TextInput`) worklet `onTextChange` fired more than once per keystroke when a change triggered a reformat, and also fired on programmatic text writes. Android already fires exactly once per user edit. # How Trigger callback only when value is updated by input change itself, and not when user manually sets the state. Matching with android. # Test Plan Repro from the issue: a `TextField` with `text={useNativeState('')}` and a masking `onTextChange` worklet that reformats the text and counts invocations via `runOnJS`. - Before: typing `5551234` counts ~9 (digits that trigger a reformat fire twice); programmatic `setText` also fires `onTextChange`. - After: counts 7 (one per keystroke); programmatic writes no longer fire `onTextChange`. # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )