Conversation
…46276) # Why Canary publishing broke when we added EJS conditional blocks (`<% if (usesExpoUI) { -%>`) to `packages/expo-module-template/$package.json`. The `updateModuleTemplate` task reads that file with `JsonFile.readAsync`, which now throws because the template is no longer valid JSON e.g. https://github.com/expo/expo/actions/runs/26419566624/job/77771270661 # How No off-the-shelf parser handles JSON-with-embedded-EJS, so the task now reads the file as text and rewrites just the version strings it cares about. # Test Plan - Smoke-tested the regex/block extraction against the current `$package.json` template: - `devDependencies.expo` is updated from `^56.0.4` to the new canary range - `peerDependencies.expo: "*"` is left untouched - The `<% if (usesExpoUI) { -%> ... <% } -%>` conditional block is preserved verbatim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )