Conversation
# Why Adds listener support to media-library@next. # How Works similar to the listeners from the legacy but: - Added dedicated manager classes - The API returns IDs - returning shared objects with sendEvent is not supported. - On Android hasIncrementalChanges is set to always false - instead of returning an empty object - Changed how race condition is handled on Android (calculates the sum of ids instead of total number of assets) # Test Plan Added tests to bare-expo
… the `<Prerequisites>` component (#45075) Co-authored-by: Kadi Kraman <hellokadi@gmail.com>
# Why In order to run `expo-observe` tests via `et native-unit-tests`, it needs to be the dependency of `native-tests` app. # How Add expo-observe as native-tests app dependency # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
## Why Precompiled failed after introducing the new ExpoModulesJSI target bridging C++ and Swift for the JSI members. ## How Added custom build to prebuilds that calls the build-xcframework.sh to ensure that ExpoModulesJSI is built as part of the prebuild. - Added custom build fields to spm.config schema - Added spm.config.json to expo-modules-jsi - Removed special handling of header files in Hermes artifacts, no longer needed (now aligns with how build-xcframeworks.sh expects the headers) - Added support for transient dependencies in spm configs - Updated misplaced ExpoModulesJSI dependency in ExpModulesCore.podspec ## Test-plan ✅ Prebuilt all used packages in release/debug version ✅ Tested in BareExpo both with/without prebuilt xcframeworks # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )