Conversation
# Why The `brownfield-tester/` directory structure is quite confusing in its current state, the `-integrated` suffix on `android-integrated` and `ios-integrated` is misleading since those folders actually contain the isolated approach, while `android/` and `ios/` are the ones that integrate with the monorepo via autolinking. # How Reorganized the folder structure into two clearly named subdirectories: - `integrated/`: Native apps that integrate directly with the monorepo using Expo autolinking - `isolated/`: Standalone native apps that consume pre-built brownfield artifacts via Maven/xcframeworks Added READMEs to both subdirectories and updated all path references across CI workflows, E2E scripts, build configs, and `.gitignore`. # Test Plan CI should be green # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Align with latest React Native core version. # How - Update package versions: - react-native 0.85.1 -> 0.85.1 - @react-native/normalize-colors 0.85.0 -> 0.85.1 - @react-native/babel-preset 0.85.0 -> 0.85.1 - @react-native/dev-middleware 0.85.0 -> 0.85.1 - @react-native/jest-preset 0.85.0 -> 0.85.1 # Test Plan - Run Bare Expo - Run Minimal tester # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )