Conversation
…38132) # Why I have not been able to reproduce this, but I have seen logs with our users where an error is thrown for one reason or another, such as: `Call to function 'ExpoSecureStore.getValueWithKeyAsync' has been rejected. → Caused by: Could not Authenticate the user: Could not authenticate the user` Then until the app is killed, any biometrics actions (get or set) will then throw a new error `Call to function 'ExpoSecureStore.getValueWithKeyAsync' has been rejected. → Caused by: Could not Authenticate the user: Authentication is already in progress`. # How Looking at the code, it seems that if `openAuthenticationPrompt` throws an error either from `assertBiometricsSupport()` or `getCurrentActivity()`, the `isAuthenticating` flag is never reset back to false, and "disables" biometrics until the app is killed. # Test Plan I haven't been able to reproduce this for my self. # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…o include an await (#38303)
…#38160) Co-authored-by: Kudo Chien <kudo@expo.dev>
# Why - Update React Compiler to align with React 19.1. It's now in RC and mostly stable. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # Test Plan The E2E test should ensure it continues working.
This reverts commit 4fcae7d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )