[pull] master from xtermjs:master#144
Merged
Merged
Conversation
Fixes #5913. Blinking is supported in renderers via TextBlinkStateManager, and bright background colors (100-107) are handled in the SGR loop. Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Register _trimListener via _register(MutableDisposable) so it is disposed when SelectionService is torn down. Use .value assignment on buffer activate instead of manual dispose/swap. Fixes #5914 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Dispose _onRemoveTextureAtlasCanvas in TextureAtlas.dispose() alongside _onAddTextureAtlasCanvas to avoid leaking listeners when the atlas is torn down. Fixes #5917 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Fixes #5920 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Headless clear() now calls buffer.clearAllMarkers() to match the browser implementation, preventing markers from surviving clear() and pointing at wrong lines. Fixes #5910 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
flushSync() processes pending writes synchronously (e.g. during CoreTerminal.resize()) but did not emit onWriteParsed, unlike the async _innerWrite path. Addons listening for parse completion could miss updates after resize. Fixes #5912 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Replace repeated string concatenation with a chunk buffer that joins once on completion. Fixes #5916. Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Underline entire wrapped OSC 8 links on hover
Register vertex array objects for disposal in GlyphRenderer and RectangleRenderer, matching existing buffer and program cleanup. Fixes #5918 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
…quality configEquals omitted deviceMaxTextureSize, deviceCellWidth, and deviceCellHeight, which could cause the char atlas cache to reuse an atlas built for a different GPU texture limit or cell size. Fixes #5915 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Replace direct console.log/warn/error calls in the WebGL addon with ILogService so messages respect the terminal logLevel and custom logger. Fixes #5921 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Fixes #5919 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Remove common/Clone.ts and its tests. Use the native structuredClone API for cloning default modes, options, and test fixtures. Fixes #5911 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
…sed-7a21 Fix flushSync() to fire onWriteParsed
…ging-7e14 Log onWillOpen handler errors instead of swallowing them
…leak-135c Fix SelectionService trim listener leak
…ut-dispose-3f04 Clear WebGL context-loss timeout on WebglRenderer dispose
…turedclone-34fc Replace custom clone utility with structuredClone
fix(headless): clear markers when clear() is called
fix(addon-webgl): use ILogService instead of console for logging
Replace PayloadStringBuffer with LimitedStringBuilder from common. Add thorough StringBuilder and LimitedStringBuilder test coverage. Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
…tter-leak-75ac Fix TextureAtlas remove-emitter leak on dispose
Remove stale FIXME comments from charAttributes JSDoc
…o-n-f60b Fix O(n²) payload accumulation in DCS/OSC/APC handlers
fix(addon-webgl): delete VAOs on renderer dispose
…-7cad fix(webgl): include texture size and cell dimensions in atlas cache equality
Replace O(n²) string concatenation in the translate loop with StringBuilder.append, matching the pattern used elsewhere in the project. Fixes #5939 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
The windowsPty option change handler checked buildNumber twice instead of requiring both backend and buildNumber to be defined. This aligns with Buffer.ts and ensures ConPTY wrapping heuristics are evaluated only when both fields are present. Fixes #5934 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
The constructor defined property getters/setters twice on _publicOptions; the first block was immediately overwritten by the second. Align with the browser public Terminal implementation. Fixes #5935 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Replace map().reduce() with one accumulator loop in reflowSmallerGetNewLineLengths to avoid allocating an intermediate array when summing wrapped line trimmed lengths. Fixes #5942 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Align headless Terminal core API with browser CoreBrowserTerminal and the public registerMarker naming. Fixes #5938 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Replace existing.push(...bucket) with an indexed loop in _mergeLineBucket to avoid intermediate array allocations during buffer trim/insert/delete re-indexing. Reuse _mergeLineBucket in _handleBufferLinesTrim for consistency. Fixes #5941 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
Avoid calling _getCurrentLinkId() twice per codepoint when a hyperlink is active by reading the link id once before the print loop. Fixes #5940 Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
…roperty-57b2 Remove duplicate Object.defineProperty loop in headless Terminal
…p-sum-705e perf: use single loop for cellsNeeded sum in BufferReflow
Avoid per-call allocation when translating many lines in sequence by resetting a module-level work StringBuilder before and after each use. Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
…-marker-22c3 Rename headless core addMarker → registerMarker
…r-guard-cbb8 Fix duplicate buildNumber guard in Windows ConPTY logic
Co-authored-by: Daniel Imms <Tyriar@users.noreply.github.com>
…d-e29d Hoist _getCurrentLinkId() in print() loop
…-5939-79f8 Use StringBuilder in BufferLine.translateToString
…loop-7132 Avoid spread when merging decoration line buckets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )