[pull] main from SigNoz:main#766
Merged
Merged
Conversation
…ag (#11642) * fix(dashboard-v2): align list & patch code with the generated client Match the now-upstream V2 client: PatchOpDTO (was JSONPatchOperationDTOOp), ListedDashboardV2DTO as the list item, and ListSortDTO/ListOrderDTO casts on the list params. No behaviour change — these files are still parked here. * feat(dashboard-v2): serve V2 dashboard pages behind use_dashboard_v2 flag Gate the dashboards list & detail entry points on useIsDashboardV2() — V1 falls through when the flag is off (V1 detail logic moved into DashboardPage.tsx). Un-park the V2 page directories in tsconfig so they typecheck and ship. Also convert the // header comments in states.module.scss to /* */ — once the V2 list is wired into the import graph, vite compiles that stylesheet and the backtick in the // comment crashed the CSS-modules parser ('Unclosed string'). * refactor(dashboard-v2): type list sort/order with the generated enums Drop the local string-literal SortColumn/SortOrder unions and the `as` casts: the nuqs query-state hooks now return DashboardtypesListSortDTO / ListOrderDTO directly, and ListHeader/DashboardsList use the enum members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )