[pull] main from SigNoz:main#761
Merged
Merged
Conversation
* chore: updated logic and use centralized function in the module * chore: filter metric groups * chore: filter metric groups * chore: formula correction * chore: added step flooring note * chore: comment correction * chore: comment correction * chore: removed function * chore: renamed variables * chore: added happy test * chore: added test 2 for accuracy and test 3 for missing metrics check * chore: added filter test 4 * chore: added 5th test for filterByStatus * chore: added group by tests * chore: pagination test added * chore: added validation tests * chore: added auth test * chore: added all tests * chore: fix for surfacing meta for pods custom group by * chore: added nodes integration test suite * chore: namespaces integration tests * ci: register inframonitoring suite + ruff format 01_hosts Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * chore: added integration tests for clusters * chore: formatting changed * chore: formatting changed * chore: formatting changed * chore: added order by host.name test * refactor(infra-monitoring): address review comments on hosts integration tests - inline _post helper at call sites - combine filter operator tests into parametrized test_hosts_filter - combine bad attr/grammar tests into parametrized test_hosts_filter_invalid - convert orderby total-invariant nested loop to stacked parametrize - drop redundant test_hosts_auth (auth covered globally) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): align pods integration tests with review feedback - inline _post helper at call sites - combine filter operator tests into parametrized test_pods_filter - combine bad attr/grammar tests into parametrized test_pods_filter_invalid - convert orderby total-invariant nested loop to stacked parametrize - drop redundant test_pods_auth (auth covered globally) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): align nodes integration tests with review feedback - inline _post helper at call sites - combine filter operator tests into parametrized test_nodes_filter - combine bad attr/grammar tests into parametrized test_nodes_filter_invalid - convert orderby total-invariant nested loop to stacked parametrize - drop redundant test_nodes_auth (auth covered globally) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): align namespaces integration tests with review feedback - inline _post helper at call sites - combine filter operator tests into parametrized test_namespaces_filter - combine bad attr/grammar tests into parametrized test_namespaces_filter_invalid - convert orderby total-invariant nested loop to stacked parametrize - drop redundant test_namespaces_auth (auth covered globally) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): align clusters integration tests with review feedback - inline _post helper at call sites - combine filter operator tests into parametrized test_clusters_filter - combine bad attr/grammar tests into parametrized test_clusters_filter_invalid - convert orderby total-invariant nested loop to stacked parametrize - drop redundant test_clusters_auth (auth covered globally) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): combine hosts groupby tests into parametrized test - merge test_hosts_groupby_hostname + test_hosts_groupby_os_type into test_hosts_groupby parametrized on (dataset, group key, expected counts/values) - preserves all assertions incl hostName populated-vs-empty branch coverage Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): combine hosts orderby tests into parametrized test - merge total_invariant_across_orderby + orderby_correctness + orderby_by_host_name into test_hosts_orderby parametrized on (column, record_field) x direction - each case asserts both the total/len invariant and sortedness; sortedness now covered for all metric columns, not just cpu - single dataset (hosts_orderby.jsonl) + CONTAINS 'order-' guard on all cases Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): combine hosts pagination tests - fold offset-beyond-total case into the test_hosts_pagination page walk (offset K+5 expects 0 records via max(0, min(limit, K-offset)); total invariant covers the beyond-total page's total == K) - single seed instead of two Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): merge hosts happy_path into test_hosts_accuracy - happy_path and value_accuracy datasets were structurally identical (same 4 metrics, same sample counts, 2 hosts); one test now asserts shape/contract + exact metric values in a single seed/request - drop unused hosts_happy_path.jsonl Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): combine pods integration tests logically - merge happy_path into test_pods_accuracy (datasets structurally identical); drop unused pods_happy_path.jsonl - merge groupby namespace/deployment into parametrized test_pods_groupby - merge orderby invariant + correctness + by-pod-name into test_pods_orderby ((column, record_field) x direction; sortedness now covered for all columns) - fold offset-beyond-total into test_pods_pagination page walk Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): combine nodes integration tests logically - merge happy_path into test_nodes_accuracy; drop unused nodes_happy_path.jsonl - merge orderby invariant + correctness + by-node-name into test_nodes_orderby ((column, record_field) x direction; sortedness now covered for all columns) - fold offset-beyond-total into test_nodes_pagination page walk Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): combine namespaces integration tests logically - merge happy_path into test_namespaces_accuracy; drop unused namespaces_happy_path.jsonl - merge orderby invariant + correctness + by-namespace-name into test_namespaces_orderby - fold offset-beyond-total into test_namespaces_pagination page walk Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): combine clusters integration tests logically - merge happy_path into test_clusters_accuracy; drop unused clusters_happy_path.jsonl - merge orderby invariant + correctness + by-cluster-name into test_clusters_orderby - fold offset-beyond-total into test_clusters_pagination page walk Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(infra-monitoring): assert metric value accuracy in hosts filter tests - regenerate hosts_filter_dataset.jsonl so every host mirrors the acc-h1 sample pattern from hosts_value_accuracy.jsonl (CI-proven expected values) - test_hosts_filter now asserts cpu/memory/wait/load15/diskUsage per filtered record against FILTER_DATASET_EXPECTED (1e-9), proving filters don't distort aggregation Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): scope filter expected values inside test_hosts_filter Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(infra-monitoring): assert metric value accuracy in pods filter tests - regenerate pods_filter_dataset.jsonl so every pod mirrors the acc-p1 sample pattern from pods_value_accuracy.jsonl (CI-proven expected values) - test_pods_filter now asserts the 6 CPU/memory fields per filtered record Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(infra-monitoring): assert metric value accuracy in nodes filter tests - regenerate nodes_filter_dataset.jsonl so every node mirrors the acc-n1 sample pattern from nodes_value_accuracy.jsonl (CI-proven expected values) - test_nodes_filter now asserts the 4 CPU/memory fields per filtered record Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(infra-monitoring): assert metric value accuracy in namespaces filter tests - regenerate namespaces_filter_dataset.jsonl so every namespace mirrors the acc-ns-1 sample pattern (2 pods) from namespaces_value_accuracy.jsonl - test_namespaces_filter now asserts namespaceCPU/namespaceMemory per record Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(infra-monitoring): assert metric value accuracy in clusters filter tests - regenerate clusters_filter_dataset.jsonl so every cluster mirrors the acc-cluster-1 sample pattern (2 nodes) from clusters_value_accuracy.jsonl - test_clusters_filter now asserts the 4 CPU/memory fields per filtered record Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): align nodes groupby + pod-phase tests with structure - merge pod_phase_counts_list_mode + _no_pods_on_node into parametrized test_nodes_pod_phase_counts ((dataset, node, filter, expected) cases) - rename groupby_cluster -> test_nodes_groupby, parametrize over k8s.node.name + k8s.cluster.name; adds the node-name-in-groupBy branch (nodeName populated, condition derived) that hosts/pods both cover Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): align namespaces groupby with structure - rename groupby_cluster -> test_namespaces_groupby, parametrize over k8s.namespace.name + k8s.cluster.name; adds the namespace-name-in-groupBy branch (namespaceName populated) that hosts/pods/nodes all cover Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(infra-monitoring): align clusters groupby with structure - rename groupby_cloud_provider -> test_clusters_groupby, parametrize over k8s.cluster.name + cloud.provider; adds the cluster-name-in-groupBy branch (clusterName populated) that hosts/pods/nodes/namespaces all cover Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )