[pull] main from SigNoz:main#738
Merged
Merged
Conversation
…e conn timeout) (#11506) * fix(telemetrystore): upgrade clickhouse-go to v2.44.0 to fix connection-pool slot leak clickhouse-go v2.43.0 introduced connection-pool slot leaks triggered by context cancellation: acquire() failed to release the pool slot when idle.Get returned a cancellation error (ClickHouse/clickhouse-go#1759), and batch.Close() never released the connection when closeQuery() failed on a cancelled context (ClickHouse/clickhouse-go#1795). Both leak slots until the pool is exhausted and every query fails with 'acquire conn timeout'. Both are fixed in v2.44.0. v2.44.0 adds HasData() to the driver.Rows interface, which the test mock did not implement. Swap the mock to the SigNoz fork github.com/SigNoz/clickhouse-go-mock v0.14.0, which implements HasData() and tracks v2.44.0. * feat(telemetrystore): emit clickhouse connection-pool metrics Register OTel observable gauges that report the clickhouse connection-pool stats from driver.Stats() on each collection cycle: signoz.telemetrystore.connection.{open,idle,max_open,max_idle}. Plotting open against max_open makes pool saturation (and leaks like the one fixed in the previous commit) directly observable in Prometheus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )