[pull] main from SigNoz:main#732
Merged
Merged
Conversation
Specially crafted inputs to idna.encode() could bypass the CVE-2024-3651 fix and cause denial-of-service. Patched in idna >= 3.15.
… generator URL (#11413) * feat(rules): use alertmanager external URL for related logs/traces and generator URL Plumbs SIGNOZ_ALERTMANAGER_SIGNOZ_EXTERNAL__URL through the rule manager so the host portion of related_logs / related_traces come from configured external URL instead of the frontend window.location captured at rule-creation time. Frontend-supplied source URL is retained as a fallback when the env var has not been set so existing self-hosted deployments keep working. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(rules)!: drop frontend source URL fallback for related logs/traces and generator URL Always derive the host portion of the rule generator URL and the related_logs / related_traces annotations from SIGNOZ_ALERTMANAGER_SIGNOZ_EXTERNAL__URL. Self-hosted deployments that have not set the env var will see the default (http://localhost:8080) in alert notifications, which makes the need to configure it surface clearly. Revert this commit to restore the prior fallback behavior. Refs SigNoz/engineering-pod#5055 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor: simplify ExternalURLHost * chore: use alert overview url for generator url * refactor(rules): source external URL via alertmanager.Config() instead of plumbing through main Address PR feedback (therealpandey): expose a Config() accessor on the alertmanager.Alertmanager interface and consume the external URL from it inside signozruler.NewFactory. This drops the *url.URL parameter that was previously threaded through cmd/community/server.go, cmd/enterprise/server.go, and pkg/signoz/signoz.go. Also switch BaseRule.GeneratorURL to *url.URL.JoinPath + Query so the URL is composed correctly when the external URL carries a base path (e.g. https://signoz.example.com/signoz) and ruleId is properly query-encoded, as suggested in review. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor: expose alertmanagerserver.Config * refactor: rename "linksTo" to "paramsFor" --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
* feat: openapi spec generation * test: script to generate test dashboard data in a sql db * test: fixes in dashboard perf testing data generator * test: perf test script for both sql flavours * test: data column in perf tests should match real data * test: much bigger json for data column * chore: comment clean up * chore: separate file for perses replicas * test: more descriptive test file name * chore: move plugin maps to correct file * chore: comment cleanup * test: add tests for spec wrappers * chore: better file names * chore: better file name * chore: too many comments * fix: js lint errors * fix: dot at the end of a comment * chore: better error messages * fix: strict decode variable spec as well * fix: remove textbox plugin from openapi spec * chore: renames and code rearrangement * chore: better comment to explain what restrictKindToLiteral does * chore: cleaner comment * chore: cleaner comment * chore: cleaner comment * chore: better method name * chore: cleanup testing code * chore: code movement * chore: code movement * chore: code movement * chore: go lint fix (godot) * chore: code movement * chore: cleanup comments * chore: better method name extractKindAndSpec * test: test for drift detection mechanics * feat: define tags module for v2 dashboard creation * feat: enum for entity type that other modules can register * chore: follow proper unmarshal json method structure * feat: v2 create dashboard API * fix: only return name of a tag in dashboard response * fix: use existing tag's casing if new tag is a prefix of an existing tag * fix: go lint fix * fix: more dashboard request validations * chore: separate method for validation * fix: module should also validate postable dashboard * test: integration tests for create API * test: integration test fixes * chore: use existing mapper * fix: remove extra spec from builder query marshalling * fix: merge conflicts * fix: add allowed values in err messages * fix: remove extra (un)marshal cycle * fix: return 500 err if spec is nil for composite kind w/ code comment * fix: no need for copying textboxvariablespec * fix: wrap errors * chore: no v2 subpackage * fix: no v2 package and its consequences * fix: no v2 package and its consequences * fix: query-less panels not allowed * feat: consolidate tag module and tagtypes changes from downstream branches * fix: allow only 1 query in a panel * test: unit test fixes * feat: method to fetch tags for multiple entries at once * test: fix mock interface in test * feat: move tags to key:value pairs model * feat: entity type column in tags * fix: pass entity type in create many * feat: reserved DSL key validation for tags * feat: new module for tags * chore: merge conflicts error fixing pt 1 * fix: lint fix regarding nil, nil return in test file * chore: change where tag module is instantiated * fix: add back api endpoint * chore: generate api spec * fix: extend bun in joinedRow * feat: method to build postable tags from tags * fix: diff error codes for invalid keys and values * fix: correct pk in bun model for tag relations * fix: created and updated by schema * fix: use coretypes.Kind instead of defining entity type * fix: singular table name * chore: remove org ID from tag relation * feat: foreign key on tag id * feat: add SyncTags method that covers creation and linking * fix: remove entity type definition * fix: fix build errors in dashboard module * chore: bump migration number * chore: change entity id to resource id * fix: add org id filter in all list and delete queries * fix: remove user auditable * fix: add ID in tag relation * fix: fix build error * chore: bump migration number * fix: add len check on tags keys and values * fix: add regex for tags * chore: remove methods that shouldn't be exposed * fix: use sync tags in create api * feat: functional unique index in sql schema * fix: only ascii in regex * chore: rename create method to createOrGet * chore: use tagtypestest package for mock store * chore: combine functional unique index with unique index * chore: move tag resolution to module * test: add unit tests for new idx type * chore: comment out tags unique index for now * chore: add a todo comment * chore: comment out unique index test * feat: add created at to tag relations * chore: comment out unique index test * chore: bump migration number * chore: remove uploaded grafana flag from metadata * Merge branch 'main' into nv/v2-dashboard-create * chore: revert idx generation to resolve conflicts * fix: use store.RunInTx instead of taking in sqlstore * fix: use binding package to get request * chore: move NewDashboardV2 to NewDashboardV2WithoutTags * chore: rename module to m * fix: add ctx needed in sqlstore * fix: remove sqlstore passage in ee pkg * chore: change dashboardData to dashboardSpec * feat: follow the metadata+spec key structure * feat: follow the metadata+spec key structure in open api spec * feat: v2 dashboard GET API (#11136) * feat: v2 dashboard GET API * Merge branch 'nv/v2-dashboard-create' into nv/v2-dashboard-get * chore: update api specs * fix: remove soft delete references * chore: embed StorableDashboard into joinedRow in store method * fix: fix build error * chore: revert all frontend changes * fix: remove public dashboard from get v2 call * chore: update frontend schema * chore: generate api specs * fix: add source for v2 dashboards * chore: incorporate source * fix: add some required fields * feat: add immutable name in dashboard v2 * feat: add immutable name in dashboard v2 * feat: add immutable name in dashboard v2 api specs * fix: remove unused param in constructor * fix: improve api descriptions * fix: remove unneeded comment * chore: increase MaxTagsPerDashboard to 10 * fix: set display name in unmarshal json * chore: remove integration test for now (will add along with list api) * feat: add validation on dashboard name * fix: correct convertor method name * test: add unit tests for type conversions * chore: remove enum def of threshold comparison operator * feat: add flag to generate unique name in backend * chore: generate api specs * chore: make tags required in postable * test: fix unit tests referring to > threshold operator * fix: use must new uuid for org id
* chore: migrate Avatar from antd to signozhq/ui Avatar * fix: pipelines to use badge instead of avatar * chore: add avatar to no-antd components
…h` (#11461) * chore: var names changed * fix: preserve order of pipelines between memory_limiter and batch * revert: test name * fix: remove old pipelines * revert: var name change * fix: changing the order; set user before custom
…raph (#11468) Replace the V3 trace colour system with the new soft 28-colour palette from the design guide. Deterministic per group value (reuses existing hashFn), theme-adaptive via darkenHex (bright base in dark mode, darkened variant in light), and reserves #FC4E4E for errors. Covers waterfall + flamegraph bars, labels, event dots, connectors, service dots, hover cards and analytics breakdown. Heat/depth modulation intentionally left out for v1.
…#11391) * refactor: replace Radio components with ToggleGroup in various components * refactor: replace ToggleGroup with ToggleGroupSimple * fix: update theme selection tests to use role-based queries * feat: add styles for add-on tab title alignment and spacing
…own (#11400) * chore: migrate dropdown * fix: self review changes * fix: side nav issue * fix: another bug * chore: migration from antd * fix: failing test * fix: lint * chore: self review comments * fix: add dropdown to list * chore: remove internal docs * chore: save antd file * fix: lint * fix: lint * chore: remove ox lint * fix: dropdown --------- Co-authored-by: Gaurav Tewari <tewarig@users.noreply.github.com>
* chore: migrate antd divider to signozhq/ui divider * fix: remove divider from routing policies
* refactor: replace antd Checkbox with @signozhq/ui Checkbox (batch 1)
Migrates mechanical checkbox callsites from antd to @signozhq/ui/checkbox:
- Trace/Filters/Panel/.../Common/Checkbox.tsx
- NewWidget/LeftContainer/ExplorerAttributeColumns.tsx
- AnomalyAlertEvaluationView.tsx
- QuickFilters/FilterRenderers/Checkbox/Checkbox.tsx
- NewSelect/CustomMultiSelect.tsx
- RolesSelect/RolesSelect.tsx
- TraceDetailsV3/.../SpanPercentilePanel.tsx
API mapping: checked -> value, defaultChecked -> defaultValue, onChange(e)
where e.target.checked is read -> onChange(checked) where checked is
CheckedState. Dropped antd-only props (type="checkbox", rootClassName ->
className, form-value `value=` semantics). RolesSelect wraps the checkbox
in a div to host pointerEvents:none since style is not in CheckboxProps.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: drop antd CheckboxChangeEvent in checkbox callsites (batch 2)
Two callsites that read e.target.checked via antd's CheckboxChangeEvent
type now receive the CheckedState (boolean | 'indeterminate') directly
from @signozhq/ui Checkbox's onChange.
- TopNav/AutoRefreshV2/index.tsx — onChangeAutoRefreshHandler signature
changes; derives boolean checked from CheckedState.
- TracesExplorer/Filter/SectionContent.tsx — onCheckHandler likewise;
also swap data-testid -> testId since SigNoz UI Checkbox wraps the
input in a div that exposes testId.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: migrate complex antd Checkbox callsites to @signozhq/ui (batch 3)
Handles the four callsites that needed shape changes, not just renames:
- RegionSelector — collapses separate `checked` + `indeterminate` props
into a single `value: true | false | 'indeterminate'` (SigNoz UI uses
CheckedState, not two props).
- InteractiveQuestion — replaces `<Checkbox.Group>` (no SigNoz UI
equivalent) with a plain `<div>` of individual `<Checkbox>`s that
push/pull from the existing `selected: string[]` state on each toggle.
- GridCardLayout/types.ts + CustomCheckBox — drops the antd-only
`CheckboxChangeEvent` type from the `checkBoxOnChangeHandler`
signature and removes the `ConfigProvider` theme override that
previously colored each chart-legend checkbox to match its series.
The dynamic per-series color is now injected via the SigNoz UI
Checkbox's exposed CSS variables
(`--checkbox-checked-background`, `--checkbox-border-color`)
applied through a wrapper `<span style={…}>`.
After this commit `grep -rE "from 'antd'.*Checkbox" frontend/src` and
`grep -rE "CheckboxChangeEvent" frontend/src` both return zero matches.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test: adapt checkbox assertions to SigNoz UI Checkbox DOM
The SigNoz UI Checkbox renders <button role="checkbox" data-state="…">
via Radix instead of antd's <input type="checkbox">. Four test suites
queried the old DOM and broke after the migration.
- TracesExplorer.test.tsx — getByTestId returns the wrapper div now (the
SigNoz UI Checkbox exposes testId on the wrapper, not the button).
Querying the inner [role="checkbox"] and asserting data-state.
- DynamicVariableDefaultBehavior.test.tsx, PanelManagement.test.tsx,
getChartManagerColumns.test.tsx — replace querySelector(
'input[type="checkbox"]') with [role="checkbox"], and .checked /
toBeChecked() with toHaveAttribute('data-state', 'checked').
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: add min-height to checkbox value section
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(meterreporter): document jitter config in example.yaml * chore(meterreporter): fix stale ResolvedJitter reference in Jitter doc comment * chore: fix comment --------- Co-authored-by: Karan Balani <29383381+balanikaran@users.noreply.github.com>
…gling CTE (#11268) * fix: trace raw export e2e * chore: separate e2e test file * chore: file rename * chore: fmtlint * fix: remove specific of timestamp * chore: fmt python * chore: remove comments * fix: alias all core columns * fix: return spans from * revert: double select * revert: build list query * chore: comments and test * revert: unused test * chore: tests updated * chore: fmt py * chore: fmt py * fix: integration tests * fix: tests rewritten * fix: replace JOIN with IN * test: wip rewrite integration tests better * fix: tests are better * fix: use pytest param * chore: fix the comments * fix: py fmt * chore: added length checks * chore: import functions from querier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )