[pull] master from mattermost:master#780
Merged
Merged
Conversation
…ise (#37060) * Add Classification Markings discovery page for non-Enterprise licenses Surface a feature discovery/upsell page in the System Console when the ClassificationMarkings feature flag is enabled but the license tier is below Enterprise (e.g. Professional). Previously the page was hidden entirely, so the feature was never surfaced to admins. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Add tests for Classification Markings discovery gating Co-authored-by: mattermost-code <matty-code@mattermost.com> * Add render test and expand gating coverage for Classification Markings discovery Co-authored-by: mattermost-code <matty-code@mattermost.com> * Assert feature flag gate overrides license for Classification Markings Co-authored-by: mattermost-code <matty-code@mattermost.com> * Run i18n-extract for Classification Markings discovery strings Co-authored-by: mattermost-code <matty-code@mattermost.com> * Fix broken learn more URL for Classification Markings discovery page The classification markings documentation page does not exist yet, causing check-external-links CI to fail. Use the CMMC compliance guide which covers system-wide and channel-specific classification banners. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Use nullish coalescing for SVG dimension defaults Address CodeRabbit feedback: honor explicit 0 width/height values instead of treating them as missing. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Address PR feedback: 0 answered, 1 resolved, 0 declined --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )