[pull] master from mattermost:master#756
Merged
Merged
Conversation
GetPreferencesForUser returns default preferences in non-deterministic order from Postgres (no ORDER BY in preference_store.GetAll), but the test asserted fixed slice indices. Look up each default preference by category instead, matching TestPluginAPIUpdateUserPreferences (#36458). Tests-only change. Verified with go test -run '^TestPluginAPIGetUserPreferences$' -race -count=100 ./channels/app. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
* Move flaky test report from PR comment to Mattermost channel Replace the github-script step that posted the flaky test summary as a PR comment with a step that posts the summary to a Mattermost channel via a new Mattermost incoming webhook (WEBHOOK_URL_FLAKY_TEST_MM). The HTML <table> summary is converted to a Markdown table, with content pipes escaped and HTML entities decoded. The existing custom flaky-test hub webhook is left untouched. Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com> * Hoist github.server_url into SERVER_URL env var Keep all GitHub Actions context expressions in the step's env block for consistency, and build PR_URL purely from shell variables. Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )