[pull] master from mattermost:master#746
Merged
Merged
Conversation
* Fix flaky TestCheckUsersEmojiIntegrity Integrity checks scan the full database for orphaned emoji rows, so parallel sqlstore tests and leftover rows from sibling tests can inflate global record counts and flip index-based assertions. Reset tables at test start and scope the one-record assertion to the emoji child ID created in that subtest. Tests-only change. Verified compilation locally; full test loop requires PostgreSQL (CI). Co-authored-by: mattermost-code <matty-code@mattermost.com> * ci: nudge CodeRabbit after all checks green Co-authored-by: mattermost-code <matty-code@mattermost.com> * Address PR feedback: 1 items resolved, 0 declined * Use t.Cleanup with require.NoError for emoji test fixture cleanup Replace silent defer dbmap.Exec cleanup calls with t.Cleanup handlers that assert on errors, addressing CodeRabbit review feedback. Co-authored-by: mattermost-code <matty-code@mattermost.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com>
* DEleted removed post from content flagging redux store * Create a separate action
…ownload rejections) (#36838) * Surface plugin upload rejections as a toast (parity with download rejections) * add some tests
) * Add server config to disable auto-follow on channel-wide mentions Adds `ServiceSettings.ChannelMentionAutoFollowThreads` (default: true) which, when disabled, prevents @channel/@here/@ALL mentions in thread replies from automatically adding users as thread followers. Users still receive mention notifications; only the thread membership is skipped. * Refactor: move channel-mention auto-follow to per-user notification setting Replaces the server-level ServiceSettings.ChannelMentionAutoFollowThreads config with a per-user notification preference channel_mention_auto_follow_threads (default: true). Users can now opt out individually via Notification Settings -> "Auto-follow threads on channel-wide mentions" (placed above "Keywords that trigger notifications"), without requiring admin intervention. Behavior is unchanged for users who have not modified the setting. * Add additional test case * linter fixes and webapp snapshot update * update user setting description * em dash removed in description * Update E2E tests * prettier:fix --------- Co-authored-by: gtsaturyan <gtsaturyan@ozon.ru> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )