[pull] master from mattermost:master#741
Merged
Merged
Conversation
… export filestore is active (#36759) * Dispatch Test Connection on ExportDriverName when dedicated export filestore is active The /file/test handler picked the mandatory-field check based on the primary DriverName even when the backend that gets constructed and tested is the export backend. A deployment with primary=S3 / export=Azure (or vice versa) therefore ran the wrong driver's field validation -- e.g. surfaced an S3-bucket error while the admin was configuring Azure, or skipped the Azure mandatory-field check entirely when the primary was Local. Introduce App.UseExportFileStore() / App.ResolvedFileStoreDriverName() and have the handler dispatch through them so validation, field selection inside the mandatory-field checks, and backend construction all agree on which side of the filestore is being tested. ------ AI assisted commit * Use refactored boolean condition in both branches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )