[pull] master from mattermost:master#670
Merged
Merged
Conversation
* fix: detect ADFS when IdpDescriptorURL has no trailing slash The ADFS detection in detectSAMLProviderType was checking for "/adfs/" (with trailing slash) but standard ADFS IdpDescriptorURL values often end with just "/adfs" (e.g. https://adfs.company.com/adfs), causing the provider type to show as "unknown" in support packets. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: lowercase FederationMetadata pattern for case-insensitive matching The normalizedURL is already lowercased, so comparing against the mixed-case literal "/FederationMetadata/" made that branch unreachable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
) * MM-68499 - auto run sync jobs on team admin abac policy creation * Use child-policy flow for access-control sync ownership test --------- Co-authored-by: Mattermost Build <build@mattermost.com>
* Avoid setting an empty value on slash command IconURL When `PostEnablePostIconOverride` is enabled and no icon URL is provided, the override icon URL was being set to empty and triggering a warning. This change updates the behavior not to set the icon at all, avoiding the triggering of the warn message while keeping the behavior. * Adds an additional check to the test --------- Co-authored-by: Miguel de la Cruz <miguel@ctrlz.es>
Automatic Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )