[pull] master from mattermost:master#662
Merged
Merged
Conversation
… deletes (#36264) * omit error_* fields if empty, add status code * MM-68378: Add tests for 404-delete semantics in ES/OS indexing jobs * MM-68378: Fix empty error fields and spurious failures for OS/ES bulk deletes - Log resp.Status unconditionally in OnFailure so status-only failures (resp.Error nil, err nil) are always identifiable - Downgrade per-item OnFailure log from Error to Warn; the job-level Error log already captures the aggregate failure - Track real failures in a separate atomic counter shared between the OnFailure callback and the close closure; 404 deletes (document not found) are silently skipped and not counted - Report num_failed from the real counter in close stats; retain stats_num_failed as the raw SDK count for reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )