[pull] master from mattermost:master#168
Merged
Merged
Conversation
…her autocompletes) (#33457) * Ensure all Suggestion rendering code always uses an array of components * Ensure all Suggestion rendering code always uses a single matchedPretext * Pass SuggestionResults around through suggestion components instead of raw arrays * Have new search component use SuggestionListStatus * Have new search and ForwardPostModal use SuggestionResults helpers * Migrate SuggestionList and AtMentionProvider to support suggestion groups * Migrate SearchSuggestionList and SearchChannelProvider to support suggestion groups * Migrate NewSearch to support suggestion groups * Make ExtensionSuggestionsProvider group results * Make ChannelMentionProvider group results * Make AppProvider and CommandProvider group results * Make EmoticonProvider group results * Don't migrate SuggestionDate to support suggestion groups * Make SearchUserProvider group results * Make SwitchChannelProvider group results * Remove lingering parts of old implementations of dividers between suggestions * Remove unused prop on SuggestionList * Update E2E tests and stop using data-testid for SuggestionList * Uncomment accidentally commented out lines * Fix quick switch modal being ordered incorrectly and unskip test * Remove leftover TODOs * Remove unused component * Fix comment * Rename suggestion_list_structure.tsx to suggestion_list_contents.tsx * Pull out isItemLoaded helper * Add a bunch of tests * Add more comments to suggestion_results.ts * Make SuggestionResults type parameter default to unknown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )