[pull] main from TryGhost:main#1217
Merged
Merged
Conversation
ref #28393 *This change should have no user impact.* If the i18n service was imported before it was initialized, its reference would be forever stale. For example, this would fail if it was run before `i18n.init()`: ```js const {t} = require('./services/i18n'); // ...some time later... console.log(t('foo')); ``` This hadn't happened yet, but we did have a test workaround for it. And an upcoming change ran into this problem, so it's time to fix it. I think this is a useful change on its own, but will also be useful for [an upcoming change](#28393).
no ref
What
----
Before this change, we had a `registerDir` function that would register
all the files in a directory with Handlebars. Pseudocode:
```js
// old pseudocode
for (const path in glob(dir)) {
const name = path.replace('.js', '');
const fn = require(path);
handlebars.register(name, fn);
}
```
After this change, we do an explicit `require` of everything.
`registerDir` is removed. Pseudocode:
```js
// new pseudocode
handlebars.register('asset', require('../../helpers/asset'));
handlebars.register('authors', require('../../helpers/authors'));
handlebars.register('body_class', require('../../helpers/body_class'));
// ...
```
Why
---
This has two main benefits:
- Startup is slightly faster.
- It's easier to convert these helpers to TypeScript now. (For example,
the old code wouldn't pick up `.ts` files.)
The main drawback is verbosity, which I think is worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )