[pull] main from TryGhost:main#1216
Merged
Merged
Conversation
no ref Added missing and newly introduced strings to the Bulgarian localization: - ghost/i18n/locales/bg/ghost.json - ghost/i18n/locales/bg/comments.json - ghost/i18n/locales/bg/portal.json
no ref - updates expired complimentary member cleanup to bump members.updated_at when transitioning members back to free - adds a unit test around the worker job using mocked DB and parentPort dependencies
ref #28310 - refactors export name handling and http stream boilerplate to reduce redundancy The members and post-analytics CSV exports each defined the `<slug>.ghost.<type>.<date>.csv` filename in up to **four** places — two API endpoints (`members`, `posts`) and two admin helpers (`getMembersExportFileName`, `getPostAnalyticsExportFileName`) — and slugified the site title two different ways (a hand-rolled regex on the client vs `@tryghost/string`'s `slugify` on the server, which transliterate non-ASCII titles differently). This duplication exists only because admin downloads fetch the export into a blob and set the filename via `a.download`, which bypasses the server's `Content-Disposition` header. So the client re-implemented what the server already knew. Now everything should be routed appropriately through the server.
…28398) no ref LinkedIn profile URLs are valid both with and without a trailing slash — `https://www.linkedin.com/in/username` and `https://www.linkedin.com/in/username/` both resolve correctly on LinkedIn. However, the front-end validator in Ghost was rejecting URLs with a trailing slash as invalid, causing friction when users paste a URL copied directly from their browser. Both forms are now accepted and normalised to the canonical form without a trailing slash.
ref https://linear.app/ghost/issue/PLA-76 The `commit-msg` hook's "user-facing changes should start with an emoji" check never recognizes an actual emoji, so the warning fires on **every** commit that correctly follows our emoji convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )