[pull] main from TryGhost:main#1212
Merged
Merged
Conversation
no ref The members CSV export filename did not include the site name, unlike the JSON export and the already-fixed analytics CSV export (#28227). This inconsistency makes it harder to identify which site the data comes from when managing multiple Ghost instances. ## What does it do? Updates the members CSV export filename to follow the same convention: `<site-name>.ghost.members.YYYY-MM-DD.csv` Falls back to `ghost.members.YYYY-MM-DD.csv` if no site title is set. ## Why is this something Ghost users need? Consistency across all exports and easier file management when handling multiple Ghost sites. This will be one of a few commits cleaning up the use, as there's both front- and back-end handling.
Fixes #28310 ## Summary - add a members export filename helper that prefixes CSV exports with the slugified site title - pass the existing settings `title` value from the members page into the export action - keep the current `ghost.members.YYYY-MM-DD.csv` fallback when the site title is unavailable ## Verification - `pnpm vitest run test/unit/views/members/members-actions.test.tsx` from `apps/posts` (7 tests passed) - `pnpm --dir apps/posts exec eslint src/views/members/components/members-actions.tsx test/unit/views/members/members-actions.test.tsx` - commit hook ESLint also covered `apps/posts/src/views/members/members.tsx` - `pnpm --dir apps/posts exec tsc --noEmit` - `git diff --check` - `pnpm --filter @tryghost/posts build` got through TypeScript and then failed in Vite/Rollup on virtual `\0react` with Node `v24.15.0`; this checkout warns the repo expects Node `^22.13.1` This is one of a few PRs to update this handling as we now recreate the member export title (and streamed exports) in a few places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )