[pull] main from TryGhost:main#1211
Merged
Merged
Conversation
no issue - following our scout rule that any files touched should be converted to TypeScript - updated our job service to pass `['--experimental-strip-types', '--import=tsx']` args through the bree config so TS can be used in background worker jobs
no issue - restrict default GHCR publishing in CI to the canonical TryGhost/Ghost repository - make direct clones use artifact mode so docker-image-production is uploaded - keep release tag GHCR publishing canonical-only and leave Trigger Pro CD restricted to TryGhost/Ghost
…8371) no issue ## Summary - stopped Admin and Content API search-index post/page requests from eager-loading tags and authors by default - preserved relation loading when `lazyRouting` is enabled because URL generation can need those relations ## Problem Large sites can spend unnecessary query and mapping work loading post/page relations that search-index responses never return or consume.
ref https://app.incident.io/ghost/incidents/298 ## Summary - Reverts cfcb48b / #25151 - Restores the JS SingleUseTokenProvider implementation and removes the TS version - Avoids job runtime failures where Node cannot resolve the tsx package from /home/ghost
towards https://linear.app/ghost/issue/NY-1286 ref #28120 This is a test-only change that just makes things a little easier to read. I think it's useful on its own, but it'll also be useful for [an upcoming change](#28120).
closes [NY-1301](https://linear.app/ghost/issue/NY-1301/design-onsave-warning-error) ### What changed - Added a confirmation dialog before deleting send email steps from the Automations canvas. - Kept the existing immediate deletion behavior for non-email steps. - allows saving automations with send_email steps that have an empty body/subject, but does not allow publishing the automation until those fields are filled in. - Added unit coverage for cancelling and confirming email deletion. This replaces #28309 but has a few extra pieces of cleanup and fixes merge conflicts from other automations changes --------- Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )