[pull] main from TryGhost:main#1210
Merged
Merged
Conversation
Admin search performance is under investigation after the dependency bump in ecab07e. This reverts only the admin package while that investigation continues.
Introduced a shared notification email primitive. It takes a resolved recipient list, sanitises the content, renders it inside a styled shell per recipient, and sends. The shell holds the chrome so notifications stay short and semantic. The sanitiser strips scripts, inline handlers and unsafe links so an untrusted upstream source cannot ship a phishing or injection payload through this path.
/llms-full.txt previously walked the full public post catalogue while building a single bounded response. On large publications that made generation latency scale with total post count, even though the response is already constrained by a 5 MiB output budget. This bounds the full export to public pages plus the latest 500 public posts. That keeps /llms-full.txt useful as a consolidated context file while giving generation a predictable upper bound of five post pages. The complete public content index remains available in /llms.txt, and a footer is added when the recent-post cap is reached so consumers know where to discover older content. The budget check now tracks generated byte length incrementally instead of repeatedly measuring the whole growing output for every candidate entry. Both truncation and recent-post footer sizes are reserved up front, so the generated response stays within the configured budget no matter which footer is needed.
ref https://linear.app/ghost/issue/BER-3700/refactor-comment-api-querying Consolidates the comments service's scattered comment-by-ID fetches into a small set of shared, status-aware lookups. Each filters status in the query and selects the internal columns the follow-up logic relies on, so field-limited API requests still resolve correctly.
no ref This change should have no user impact.
no ref This change should have no user impact.
Follow-up to #44af74370c, which made the adapter "missing dependency" error reachable again. That error said dependencies were missing but not *which* one. This parses the module name from the `MODULE_NOT_FOUND` first line and includes it: > You are missing a dependency `'superagent'` in your adapter `core/server/adapters/scheduling/SchedulingPro` Falls back to the existing wording if no specifier can be parsed. Minor actionability improvement, no behavior change. - `adapter-manager.js`: extract and include the unresolved module name - `adapter-manager.test.js`: assert the name appears in the error
closes https://linear.app/ghost/issue/ONC-1808/ ## Summary - Keeps admin search index refreshes alive across restartable search keystrokes - Expires cached admin search content when indexed post fields change or posts are deleted - Adds the direct chalk dependency required by the admin Ember build under pnpm ## Root cause `searchTask` is restartable, so refresh task instances started from it were cancelled on later keystrokes while the underlying AJAX requests continued. That left the cache stale and allowed another full search-index refresh to start. The fix starts refreshes with `refreshContentTask.unlinked().perform()` so the refresh task is not linked to the restartable search task that triggered it. That lets the in-flight index refresh complete and update the shared cache, while the provider's `drop` task behavior still prevents duplicate refreshes from starting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )