[pull] main from TryGhost:main#1207
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/DES-1385/typography-consolidation - Consolidates admin typography classes across Shade, AdminXDS, Settings, Posts, Stats, and Ember admin surfaces. - Updates the admin sidebar submenu treatment, including shared submenu items, indentation guides, truncation, spacing, and focus behavior. - Aligns Ember header and breadcrumb behavior so detail/list page titles work better with breadcrumbs and responsive actions. - Tightens shared admin page width tokens to keep Ember and React admin pages visually consistent. - Normalizes Ember form control sizing, including the tag color input height. - Refines Ember member detail proportions, including the smaller member avatar size. ## Testing - Ran targeted ESLint checks while touching the sidebar, submenu, and list page work. - Ran `pnpm --dir ghost/admin build:dev` to verify Ember CSS output while adjusting shared width tokens. - Ran `pnpm --dir apps/admin exec vite build` to refresh and verify generated Admin/Shade CSS output. - Verified relevant sidebar and list/header layout changes in browser with Playwright screenshots and DOM measurements.
towards https://linear.app/ghost/issue/NY-1286 ref #28120 This change should have no impact on functionality. We have [a lint rule that limits the length of `index.js` files][0]. In [an upcoming change][1], the automations service will cross that limit. This patch moves it into a separate file. Doing so also makes it a little easier to test. [0]: https://github.com/TryGhost/eslint-plugin-ghost/blob/22d154a8e3807e4e30219fb8449e7aa9b90a110b/lib/config/node.js#L32-L37 [1]: #28120
closes https://linear.app/ghost/issue/NY-1283 - Deduplicates automation action revisions in the fake database automations repository so editing an automation only creates a new revision when action data actually changes. - Adds unit coverage for unchanged edits, changed wait actions, and newly added actions. Co-authored-by: Evan Hahn <evan@ghost.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )