[pull] main from TryGhost:main#1182
Merged
Merged
Conversation
no issue Our comments API was updated to return all replies rather than limiting to 3 per top-level comment in #26755. This PR cleans up the remaining+unused client-side code for fetching unloaded replies because it was tripping up agents. ## Summary - removes the obsolete `serverHasMore` reply-fetch fallback from threaded and non-threaded comments UI - keeps reply pagination client-side only now that the API returns all embedded replies - removes the stale `total_replies` comments-ui type and old partial-reply e2e coverage
…#28124) The vertical lines linking nested replies were rendered as 1px-wide divs filled with a background colour. At certain DPI scales and zoom levels browsers painted these 2-3px wide, which gave the appearance of two parallel lines next to the cleanly-rendered elbow connectors. Switched the lines to use `border-l`, the same render path the elbow connectors already use, so reply, continuation and elbow lines all align on whole-pixel boundaries and render consistently.
ref https://linear.app/ghost/issue/PLA-48 Mend's hosted Renovate ticks every ~4h. With `platformAutomerge: false` (intentional, so merges stay inside `automergeSchedule`) and `branchConcurrentLimit: 10`, each merge forces every other open Renovate branch to rebase, and the rebased CI doesn't finish before the next tick. Net throughput is ~1 PR per tick — capped at ~2 PRs per weeknight automerge window and ~5–6 per weekend day. Small backlogs take all weekend to drain, and the concurrent-branch cap saturates the queue.
ref https://linear.app/ghost/issue/BER-3685/ga-threading-and-pinned-comments Readers can now follow deeper reply conversations with threaded comments available to everyone.
ref https://linear.app/ghost/issue/BER-3685/ga-threading-and-pinned-comments Staff can now pin top-level comments so important discussion stays visible for readers.
ref https://linear.app/ghost/issue/BER-3685/ga-threading-and-pinned-comments Threaded comments now hide the reply-to-reply context label, so the public comments E2E should assert that layout instead of the legacy flat reply copy.
towards https://linear.app/ghost/issue/NY-1286 **What?** Rename "poll" to "welcome email automation poll". No expected user impact. **Why?** We plan to add a new polling system (see [NY-1286]) but keep the current one for awhile. Let's rename the current one so we can have both, and make the distinction clear. [NY-1286]: https://linear.app/ghost/issue/NY-1286
fixes #28076 - constrained generic hyphen-separated permalink params so earlier params stop at the hyphen and the final param can keep a hyphenated slug - kept dated permalink regression coverage and added a non-date `:section-:slug` case using fabricated URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )