[pull] main from TryGhost:main#1178
Merged
Merged
Conversation
towards https://linear.app/ghost/issue/NY-1286 This change should have no user impact. Before (pseudocode): ```javascript const enqueuePollNow = () => { dispatch(StartAutomationsPollEvent.create()); }; const enqueuePollAt = (date) => { scheduler.at(date, 'PUT', '/automations/poll'); }; ``` After (pseudocode): ```javascript const enqueuePollAt = (date) => { if (new Date() < date) { dispatch(StartAutomationsPollEvent.create()); } else { scheduler.at(date, 'PUT', '/automations/poll'); } }; ``` I think this is a useful change on its own (makes it easier for functions that want this behavior), but it'll also make [an upcoming change][0] easier. [0]: https://linear.app/ghost/issue/NY-1286
no ref *I recommend reviewing this change commit-by-commit.* The private blogging middleware exported `authenticatePrivateSession`, which was only used internally. This change, which should have no user impact, makes it private instead of exporting it. Most significantly, that meant updating a few tests.
no ref - avoids loading the pushed full production image into the local Docker daemon on trusted CI runs - skips the non-gating Docker image size/layer summary on trusted runs, because it depends on the image being loaded locally - keeps local loading and image inspection for artifact-based fork/cross-repo PR runs ## Why The full image is already pushed to GHCR on trusted runs. Loading it locally is only needed for artifact transfer/reporting and was adding roughly 45-60s of export/import overhead after BuildKit cache hits. The skipped reporting is informational only: it runs `docker inspect` and `docker history` to write image size and layer details to the GitHub Step Summary. It does not enforce thresholds, alert, or gate CI.
no ref - skips dependency lifecycle scripts during the temporary `pnpm deploy` used by `ghost archive` - keeps the existing archive validation and install-time package metadata intact ## Why `pack.js` removes `ghost/core/package/node_modules` before creating the Ghost-CLI archive, so native install work done during deploy is discarded. On Blacksmith this exposed a costly sqlite3 fallback compile when `prebuild-install` timed out; skipping scripts avoids that wasted work without making this Blacksmith-specific.
no ref CVE-driven dependency updates have been getting stranded for weeks. Renovate's weekend-only schedule and the dashboard-approval gate for major bumps apply equally to security PRs, so a green-CI security patch can sit until merge conflicts pile up.
closes https://linear.app/ghost/issue/NY-1257 https://github.com/user-attachments/assets/fc9315d4-f7f4-49f6-ac71-f059bf5c1ce1 This was largely written by GPT-5.5 (High) with the following prompt: > Currently, the Automations editor has no way to save an inactive automation without publishing it. For example, if you're working on an automation and haven't finished but need to walk away, you want to click Save, not Publish. Let's add this. > > When an automation is inactive, add a secondary "Save" button to the left of the publish button in `<AutomationHeader>`. Clicking this button should call `editMutation.mutate()` like we already do in `Automations/editor.tsx`, but it shouldn't change the `status`. > > When an automation is active, I don't want it to look any different from today. There should be no "Save" button or anything different in that part of the UI. > > Use red/green TDD to accomplish this. I manually cleaned up a small amount afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )