fix(compaction): admit prompts during breaker cooldown - #556
Merged
code-yeongyu merged 1 commit intoJul 31, 2026
Conversation
Allow opportunistic compaction admission to degrade when the latest rejection is the circuit breaker, while preserving fail-closed behavior for genuine overflow and other cancellation causes.\n\nCloses #531\n\nCo-authored-by: effortprogrammer <yhjhoward7@gmail.com>
code-yeongyu
deleted the
fix/issue-531-compaction-cooldown-admission-task
branch
July 31, 2026 02:44
This was referenced Jul 31, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This supersedes #532 on current
main, preserving the original contributor's implementation and co-author attribution. It does not overlap #527's separate blocking-route breaker/cap enforcement in the builtin compaction extension.RED -> GREEN
origin/main:531-compaction-cooldown-admission.test.tsfailed withRequiredCompactionErrorat_enforceCompactionBeforeProvider; non-breaker control passed.Verification
npm run check: passed.local-ignore/qa-evidence/20260731-issue-531-breaker-admission/cli-qa.logCloses #531
Summary by cubic
Admit prompts during compaction breaker cooldown to prevent bricked sessions during provider outages. Non-breaker cancellations and true overflow still block as before.
circuit-breakercooldown.Written for commit 48682cb. Summary will update on new commits.