fix(model-requirements): use supported variant for gemini-3-pro#1463
Merged
code-yeongyu merged 2 commits intodevfrom Feb 4, 2026
Merged
fix(model-requirements): use supported variant for gemini-3-pro#1463code-yeongyu merged 2 commits intodevfrom
code-yeongyu merged 2 commits intodevfrom
Conversation
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 3/5
- Potential user-impacting issue:
src/tools/delegate-task/constants.tsstill usesvariant: "max"forartistry, which likely triggers API errors after the Gemini 3 Pro variant update. - Score reflects a concrete regression risk (severity 6/10) tied to the delegate task flow rather than a minor or speculative issue.
- Pay close attention to
src/tools/delegate-task/constants.ts- updateDEFAULT_CATEGORIESvariant to align with the new Gemini 3 Pro requirements.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/shared/model-requirements.ts">
<violation number="1" location="src/shared/model-requirements.ts:34">
P2: Gemini 3 Pro variant update is incomplete.
`src/tools/delegate-task/constants.ts` still uses `variant: "max"` for the `artistry` category in `DEFAULT_CATEGORIES`. This will likely cause API errors when using the `delegate_task` tool with this category.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| fallbackChain: [ | ||
| { providers: ["openai", "github-copilot", "opencode"], model: "gpt-5.2", variant: "high" }, | ||
| { providers: ["google", "github-copilot", "opencode"], model: "gemini-3-pro", variant: "max" }, | ||
| { providers: ["google", "github-copilot", "opencode"], model: "gemini-3-pro", variant: "high" }, |
There was a problem hiding this comment.
P2: Gemini 3 Pro variant update is incomplete.
src/tools/delegate-task/constants.ts still uses variant: "max" for the artistry category in DEFAULT_CATEGORIES. This will likely cause API errors when using the delegate_task tool with this category.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/shared/model-requirements.ts, line 34:
<comment>Gemini 3 Pro variant update is incomplete.
`src/tools/delegate-task/constants.ts` still uses `variant: "max"` for the `artistry` category in `DEFAULT_CATEGORIES`. This will likely cause API errors when using the `delegate_task` tool with this category.</comment>
<file context>
@@ -31,7 +31,7 @@ export const AGENT_MODEL_REQUIREMENTS: Record<string, ModelRequirement> = {
fallbackChain: [
{ providers: ["openai", "github-copilot", "opencode"], model: "gpt-5.2", variant: "high" },
- { providers: ["google", "github-copilot", "opencode"], model: "gemini-3-pro", variant: "max" },
+ { providers: ["google", "github-copilot", "opencode"], model: "gemini-3-pro", variant: "high" },
{ providers: ["anthropic", "github-copilot", "opencode"], model: "claude-opus-4-5", variant: "max" },
],
</file context>
- Update DEFAULT_CATEGORIES artistry variant from 'max' to 'high' - Update related test comment - gemini-3-pro only supports low/high thinking levels, not max - Addresses Oracle review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1433
Changed
variant: "max"tovariant: "high"forgemini-3-profallback entries across agents and categories.According to Google's Gemini API documentation, Gemini 3 Pro only supports
"low"and"high"thinking levels:Using
"max"results in API errors (400 Bad Request) when the fallback resolves to Gemini 3 Pro.Changes
oraclevariant: "max"→variant: "high"metisvariant: "max"→variant: "high"momusvariant: "max"→variant: "high"ultrabrainvariant: "max"→variant: "high"deepvariant: "max"→variant: "high"artistryvariant: "max"→variant: "high"Notes
"high"is already the maximum thinking level supported by Gemini 3 Proclaude-opus-4-5withmax,gpt-5.2withhigh) correctly use their respective variantsRelated
Summary by cubic
Fix 400 errors by switching Gemini 3 Pro fallbacks from variant "max" to "high" so thinking mode is valid. Aligns with Google’s docs and addresses #1433.
Written for commit 7a8a84d. Summary will update on new commits.