fix(model-requirements): use provider-specific variants for github-copilot#1422
Open
ilarvne wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix(model-requirements): use provider-specific variants for github-copilot#1422ilarvne wants to merge 1 commit intocode-yeongyu:devfrom
ilarvne wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
…pilot GitHub Copilot Claude models only support 'standard' and 'thinking' variants, not 'max' which is supported by the direct Anthropic API. Similarly, Copilot Gemini models support 'high' but not 'max'. Split fallback chain entries so that: - anthropic/opencode providers use 'max' variant for Claude models - github-copilot provider uses 'thinking' variant for Claude models - google/opencode providers use 'max' variant for Gemini models - github-copilot provider uses 'high' variant for Gemini models This prevents sending unsupported variant values to the Copilot API.
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Author
|
I have read the CLA Document and I hereby sign the CLA |
leoisadev1
pushed a commit
to leoisadev1/oh-my-opencode
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub Copilot's Claude models only support
standardandthinkingvariants (fixed 4K thinking budget), notmaxwhich is supported by the direct Anthropic API. Similarly, Copilot's Gemini models supporthighbut notmax.This PR splits fallback chain entries in
model-requirements.tsso that provider-specific variants are used:Changes
["anthropic", "github-copilot", "opencode"]entries into separate provider-specific entriesTesting
bun test src/shared/passes (435 tests)thinkingfor github-copilot Claude modelshighfor github-copilot Gemini modelsChecklist
bun run typecheckpassespackage.jsonSummary by cubic
Use provider-specific model variants so GitHub Copilot gets supported options for Claude and Gemini, preventing unsupported-variant errors. Improves reliability of model selection across agents and categories.
Written for commit 3f1808f. Summary will update on new commits.