fix: respect TUI variant (ctrl+t) and inherit it for auto prompts#1275
Open
Hisir0909 wants to merge 2 commits intocode-yeongyu:devfrom
Open
fix: respect TUI variant (ctrl+t) and inherit it for auto prompts#1275Hisir0909 wants to merge 2 commits intocode-yeongyu:devfrom
Hisir0909 wants to merge 2 commits intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
… prompts - keyword-detector: use input.variant if provided, fallback to parent variant - atlas: pass parent variant to auto-generated prompts for consistency - background-agent: ensure variant precedence in provider-aware inference - tests: add coverage for variant inheritance and precedence scenarios
…recedence - extract variant precedence logic to chat-message-variant utility - prevent firstMessageVariantGate from overriding user-selected variant - ensure consistent variant handling across all message types - tests: add coverage for variant precedence scenarios
374654c to
e93525c
Compare
leoisadev1
pushed a commit
to leoisadev1/oh-my-opencode
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variant(ctrl+t / variant_cycle) is never overridden by plugin defaults, including on the first message of a new sessionvariantfor consistent reasoning levelChanges
input.variantand use provider/model-aware ultrawork variant inference only as fallbackvariantwhen sending completion notifications to the parent sessionvariantwhen injecting boulder continuation promptsTesting
bun run typecheck bun testRelated Issues
Closes #521
Summary by cubic
Respect the user-selected reasoning variant (Ctrl+T) across all messages and make auto-generated prompts inherit the parent session’s variant. Centralizes variant precedence to prevent defaults from overriding user choice and improves ultrawork variant inference.
Bug Fixes
Refactors
Written for commit e93525c. Summary will update on new commits.