fix: skip notification when background tasks are still running#1249
Open
subtleseeker wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix: skip notification when background tasks are still running#1249subtleseeker wants to merge 1 commit intocode-yeongyu:devfrom
subtleseeker wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Add hasPendingBackgroundTasks callback to SessionNotificationConfig that allows session-notification to check if there are running background tasks before sending a notification. This fixes the issue where notifications would fire when a background agent completes, even if other background agents are still running. The notification should only fire when the session is truly idle (no background tasks running and waiting for user input).
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign the CLA, please comment on this PR with: This is a one-time requirement. Once signed, all your future contributions will be automatically accepted. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasPendingBackgroundTaskscallback toSessionNotificationConfiginterfaceindex.tsto usebackgroundManager.getRunningTasks()Problem
Notifications fire when a background agent completes, even if other background agents are still running. This happens because:
notifyParentSession()which prompts the parent sessionsession.idleevent fires for the parent (main) sessionSolution
Add a new optional callback
hasPendingBackgroundTasksto theSessionNotificationConfigthat is checked before sending a notification. WhenbackgroundManager.getRunningTasks().length > 0, the notification is skipped.This ensures notifications only fire when the session is truly idle (no background tasks running and waiting for user input).
Testing
Built and tested locally. The fix correctly skips notifications when background tasks are still running.
Summary by cubic
Prevented session notifications from firing while any background tasks are still running. Notifications now trigger only when the session is truly idle.
Written for commit 7b3b9ab. Summary will update on new commits.