feat(shared-skills): add global pr workflow - #7137
Open
feelsodev wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@code-yeongyu All required checks are green and the PR is mergeable. Could you review and merge it with a merge commit when ready? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This adds a self-contained global
prskill to the cross-harness shared-skills bundle. It preserves the existing b2b-dashboard PR workflow defaults while removing the dependency on a repository-local Claude command, and it lets stricter repository policy narrow the workflow without widening user authorization.Changes
Shared PR workflow
packages/shared-skills/skills/pr/SKILL.mdwith full-diff inspection, branch/base guards, diff-grounded title and body generation, safe push/create behavior, and server-side PR read-back.Cross-harness distribution
pr.prto the Senpi packaged-skill inventory and the closedskill_loaded.skill_nametelemetry enum, with the generated telemetry reference kept byte-exact.Verification
pr/SKILL.mdcopies: byte-identical.codex app-serverturn discovered the skill; real~/.codex/config.tomlstayed unchanged.RESULT=FIXED; the real OpenCode database stayed unchanged.realSenpiUntouched: true.Residual risk
subagent-limit-migration.test.mjsfailure. The same focused test fails identically on a clean detachedorigin/devworktree at63bfdb770; the affected Codex sync suite is green.typescript-language-serveris not installed on the workstation; repository typechecks and scoped tests passed instead.Summary by cubic
Adds a global
prshared skill that creates GitHub pull requests from the actual commits and full diff, replacing repository‑local PR commands while preserving repository policy. This unifies PR creation across harnesses without widening user authorization.Behavior and safety
gh pr createvia an owner‑only temp file, and server‑side read‑back; repository policy wins and repository guidance is treated as untrusted.Distribution and rollout
prin@oh-my-opencode/shared-skills; Codex aggregate and OpenCode loader discover/load it, with an explicit Codex test asserting inclusion.skill_loaded.skill_nametelemetry enum and docs; regeneratesomo-senpiextension bundles.AGENTS.mdto 18 skills includingpr.Written for commit 646191d. Summary will update on new commits.