fix: remove stale process listener test helper - #7045
Open
WyvernMonarch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove an unused process-listener test helper whose broad event union no longer typechecks against Bun's typed
process.listeners()overloads. Production cleanup registration and every active process-cleanup test seam remain unchanged.Changes
ProcessCleanupEventalias.getNewListenerhelper.getRegisteredProcessCleanupSignalListenerandflushMicrotasks, which are used by the process-cleanup test suite.QA & Evidence
bun run typecheck..omo/evidence/20260819-process-cleanup-listener-types/baseline-typecheck.txt,.omo/evidence/20260819-process-cleanup-listener-types/typecheck.txtbun test packages/omo-opencode/src/features/background-agent/process-cleanup.test.ts..omo/evidence/20260819-process-cleanup-listener-types/targeted-test.txtbun test packages/omo-opencode..omo/evidence/20260819-process-cleanup-listener-types/qa-summary.mdbun run build..omo/evidence/20260819-process-cleanup-listener-types/build.txtservewith the built worktree plugin as the only configured plugin in isolated HOME/XDG directories.server.connectedobserved, live user DB stayed at 5,492 sessions before and after..omo/evidence/20260819-process-cleanup-listener-types/run-opencode-smoke.sh,.omo/evidence/20260819-process-cleanup-listener-types/opencode-smoke.txtRisks & Residuals
bun testrun produced 15,888 passes and three unrelated failures outsidepackages/omo-opencode; details and classification are recorded in the QA summary. The completepackages/omo-opencodesuite is green.Summary by cubic
Removes an unused process-listener test helper to fix Bun type errors without changing runtime behavior. The old helper used a broad event union that broke
process.listeners()overloads (TS2769/TS2322); it is now deleted and typecheck passes.packages/omo-opencode/src/features/background-agent/process-cleanup.test-helpers.tsonly. DeletesProcessCleanupEventandgetNewListener; keepsgetRegisteredProcessCleanupSignalListenerandflushMicrotasks.Written for commit 0469595. Summary will update on new commits.