fix(keyword-detector): ignore ulw skill names - #7025
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
a187641 to
03b2088
Compare
iggykimi
left a comment
There was a problem hiding this comment.
Independent verification on Windows 11 (the platform where this PR's README notes the repo prepare build fails) — @iggykimi
bun install: clean (1246 packages, ~260s)- Focused gate:
bun test packages/omo-opencode/src/hooks/keyword-detector/ultrawork-edge-trigger.test.ts→ 6 pass / 0 fail / 25 assertions - Full suite:
bun test packages/omo-opencode/src/hooks/keyword-detector/→ 92 pass / 0 fail / 245 assertions
Boundary semantics confirmed live on Windows: standalone ulw, ultrawork, ulw-loop activate; ulw-plan and ulw-research no longer double-inject the ultrawork mode prompt. Matches the Codex-side guard behavior.
LGTM — thanks for including the .omo/evidence/ artifacts.
|
Follow-up to my approval above, with precise scope:
|
|
Thanks for the precise Windows follow-up. The 92-test keyword-detector run and full prepare exit 0 close the Windows build uncertainty recorded in the PR, and your pattern comparison confirms the OpenCode guard matches the established Codex behavior. I also rechecked the current dev branch: it still has the unguarded ultrawork/ulw pattern, so this PR remains the only OpenCode-side fix. No code change is needed from this feedback. |
Summary
ulw,ultrawork, and the distinctulw-loopboundary activeulw-planandulw-researchskill names from double-injecting ultrawork modeTests and QA
npx --yes bun test packages/omo-opencode/src/hooks/keyword-detector/ultrawork-edge-trigger.test.ts(6 passed)npx --yes bun test packages/omo-opencode/src/hooks/keyword-detector(92 passed)npx --yes bun x tsgo --noEmit -p packages/omo-opencode/tsconfig.jsonconstants.tsThe repository prepare build still reaches the known Windows-only
lsp-tools-mcpPOSIXrmportability failure. The focused tests, complete detector suite, package typecheck, targeted bundle, and isolated probe pass independently.Risk
Low. The regex change matches the established Codex detector and only narrows two hyphenated skill-name boundaries.
Related: #6876