-
Notifications
You must be signed in to change notification settings - Fork 16
ci: invalidate nx cloud cache for different operating system #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit 7b5c5be
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/core
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 6aafd5a with previous commit 97c31f8. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 1 group regressed, 👍 1 audit improved, 👎 3 audits regressed, 13 audits changed without impacting score🗃️ Groups
20 other groups are unchanged. 🛡️ Audits593 other audits are unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like it!
329a01d
to
7b5c5be
Compare
I'm curious how you tested it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
We run CI jobs on different operating systems to ensure platform compatibility. Now that Nx Cloud is in play, though, we need to make sure cache isn't reused between them - the same source code may pass on Linux and fail on Windows, for example.
I've set the
os.platform()
value (along withnode -v
) as a shared global, so that Nx uses this info in its cache keys. I've tested the command on both Linux and Windows to make sure it works everywhere (not easy to figure out, different shells, quote handling etc. 😅), came up withnode -e "console.log(require('os').platform())"
.