chats: add (temporary) plumbing for tip notifications. #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfycheng
force-pushed
the
two-way-chats-tips
branch
from
1f75e99 to
7cacfa1
Compare
mfycheng
force-pushed
the
two-way-chats-tips
branch
from
20ab170 to
b3dd20c
Compare
mfycheng
force-pushed
the
two-way-chats-tips
branch
from
77ab896 to
aa0ef97
Compare
…s#186) * update intent DB models to support pay-for-chat intents * Update to latest code-protobuf-api, and apply related fixes
Adds enough plumbing for the tip notifications to flow through v2 (without breaking the previous system, hopefully). When the protocol is more flushed out, and the base messaging infra is shored up a bit, this will likely be revisted
Turns out we're being called in a transaction up in the chain. There should be a better way to detect (or noop) this behaviour Turns out we're being called in a transaction up in the chain. There should be a better way to detect (or noop) this behaviour
Also refactor a bit of the notifier system to not cause a circular dependency.
mfycheng
force-pushed
the
two-way-chats-tips
branch
from
5849167 to
e4c7860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds enough plumbing for the tip notifications to flow through v2 (without breaking the previous system, hopefully). When the protocol is more flushed out, and the base messaging infra is shored up a bit, this will likely be revisted