Skip to content

Commit b49115c

Browse files
authored
Use base58 for FiatOnrampPurchase message encoding (#111)
1 parent 09849db commit b49115c

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

pkg/code/thirdparty/message.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package thirdparty
33
import (
44
"crypto/ed25519"
55
"crypto/rand"
6-
"encoding/base64"
76
"encoding/binary"
87
"strings"
98
"time"
@@ -299,14 +298,14 @@ func (m *FiatOnrampPurchaseMessage) Encode() ([]byte, error) {
299298

300299
buffer = append(buffer, m.Nonce[:]...)
301300

302-
return []byte(base64.StdEncoding.EncodeToString(buffer)), nil
301+
return []byte(base58.Encode(buffer)), nil
303302
}
304303

305304
// DecodeFiatOnrampPurchaseMessage attempts to decode a byte payload into a FiatOnrampPurchaseMessage
306305
func DecodeFiatOnrampPurchaseMessage(payload []byte) (*FiatOnrampPurchaseMessage, error) {
307306
errInvalidPayload := errors.New("invalid payload")
308307

309-
buffer, err := base64.StdEncoding.DecodeString(string(payload))
308+
buffer, err := base58.Decode(string(payload))
310309
if err != nil {
311310
return nil, errors.Wrap(err, errInvalidPayload.Error())
312311
}

pkg/code/thirdparty/message_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func TestFiatOnrampPurchase_CrossPlatform(t *testing.T) {
8181
msg, err := NewFiatOnrampPurchaseMessage(nonce)
8282
require.NoError(t, err)
8383

84-
expected := "AQAAAAAAwko78q1PR1aUToGUj/EIgg=="
84+
expected := "Gk2Yb7W6BypLsdRoJqMAqXHDoV2jT"
8585
actual, err := msg.Encode()
8686
require.NoError(t, err)
8787
assert.Equal(t, expected, string(actual))

0 commit comments

Comments
 (0)