Use base58 encoded Twitter registration nonce value (#110)

jeffyanta · web-flow · commit 09849dbc6059 · 2024-04-09T13:11:02.000-07:00
diff --git a/pkg/code/async/user/twitter.go b/pkg/code/async/user/twitter.go
@@ -283,10 +283,14 @@ func (p *service) findVerifiedTipAccountRegisteredInTweet(ctx context.Context, t
 		}
 		tipAccount, _ := common.NewAccountFromPublicKeyBytes(decodedAddress)
 
-		nonce, err := uuid.Parse(nonceString)
+		decodedNonce, err := base58.Decode(nonceString)
 		if err != nil {
 			return nil, nil, errTwitterInvalidRegistrationValue
 		}
+		if len(decodedNonce) != 16 {
+			return nil, nil, errTwitterInvalidRegistrationValue
+		}
+		nonce, _ := uuid.FromBytes(decodedNonce)
 
 		decodedSignature, err := base58.Decode(signatureString)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -283,10 +283,14 @@ func (p *service) findVerifiedTipAccountRegisteredInTweet(ctx context.Context, t`
`283`	`283`	`}`
`284`	`284`	`tipAccount, _ := common.NewAccountFromPublicKeyBytes(decodedAddress)`
`285`	`285`
`286`		`- nonce, err := uuid.Parse(nonceString)`
	`286`	`+ decodedNonce, err := base58.Decode(nonceString)`
`287`	`287`	`if err != nil {`
`288`	`288`	`return nil, nil, errTwitterInvalidRegistrationValue`
`289`	`289`	`}`
	`290`	`+ if len(decodedNonce) != 16 {`
	`291`	`+ return nil, nil, errTwitterInvalidRegistrationValue`
	`292`	`+ }`
	`293`	`+ nonce, _ := uuid.FromBytes(decodedNonce)`
`290`	`294`
`291`	`295`	`decodedSignature, err := base58.Decode(signatureString)`
`292`	`296`	`if err != nil {`