Fix/num traits peer dependency#87
Open
piliugin-anton wants to merge 2 commits intocodama-idl:mainfrom
Open
Conversation
🦋 Changeset detectedLatest commit: 676d1e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: include
num-traitsin Cargo.toml whennum-deriveis usedProblem
When
syncCargoToml: true, the generatedCargo.tomlincludesnum-derivebut notnum-traits, causingerror[E0463]: can't find crate for num_traits. Althoughnum-traitsis listed inDEFAULT_DEPENDENCY_VERSIONS, that map is only a version lookup table — a dependency only gets added toCargo.tomlif it's first detected as "used" by scanning rendered source for crate references. The scanner correctly findsnum_derivefrom#[derive(num_derive::FromPrimitive)]in generated code, butnum_traitsnever appears in source — it's only referenced inside the proc-macro expansion thatrustcproduces at compile time. Since the scanner never seesnum_traits, it's never looked up inDEFAULT_DEPENDENCY_VERSIONSand never written toCargo.toml.Fix
Adds a
PEER_DEPENDENCIESmap that declares runtime crates required by proc-macro crates (num-derive→num-traits). After the initial import scan ingetUsedDependencyVersions(), a newexpandPeerDependencies()step adds any missing peers, respecting user-provided version overrides and routing unresolvable peers through the existing error path.