-
Notifications
You must be signed in to change notification settings - Fork 37
Podman updates & More Competition container security #1871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ObadaS
wants to merge
18
commits into
develop
Choose a base branch
from
podmanUpdates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…container to launch containers on host instead of inside the container
…socket connections issues
…ll to the submission container launch options, changed volume mounting option for podman
I also wanted to note that I don't think the Circle-CI tests does anything with podman images, I am pretty sure that it only uses docker images build from Dockerfiles |
✅ Test 1: Test if submission works using docker container (testing changes in compute_worker.py) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the purpose of the changes contained in this PR.
This PR updates the
Containerfile.compute_worker_podman
andContainerfile.compute_worker_podman_gpu
.Updated base image version to get the latest security fixes, removed all the unnecessary lines to create lighter images (especially the GPU image)
I also updated the
compute_worker.py
file to add more security and make it more compatible to Podman.Checklist for hand testing
For Docker compute workers (compute_worker.py updates)
For Podman
systemctl --user enable --now podman
podman build -t codalab/codabench_worker_podman:latest -f Containerfile.compute_worker_podman
/codabench
folderdata
folder inside the/codabench
sudo chown -R user:user /codabench
).env
fileChecklist