Skip to content

ensure the init job is created as a helm hook so the chart can be upgraded #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JorritSalverda
Copy link
Contributor

fixes #45

@JorritSalverda
Copy link
Contributor Author

Hi @JuanLeon1 @DuskEagle any chance this can be approved, merged and released in the next version?

@DuskEagle
Copy link
Member

DuskEagle commented Apr 9, 2021

LGTM if you could update the Chart.yaml version as mentioned in Contributing.md. Thank you!

@DuskEagle DuskEagle self-requested a review April 9, 2021 14:53
@jonasbadstuebner
Copy link

Are you sure this works on first install as well?
Because it will not create the hook necessary for init, until after the installation would complete, which it doesn't if you handle it like this.

@prafull01
Copy link
Collaborator

Are you sure this works on first install as well? Because it will not create the hook necessary for init, until after the installation would complete, which it doesn't if you handle it like this.

Hi @jonasbadstuebner
It would work on the first install as well, however if you are using --wait, then post install hook doesn't get triggered and in that case it fails.
If you are not using --wait, then yes your statefulset gets created first, your crdb pods will not come up until post install hook gets completed and after that cockroachdb pod comes up properly.

@jonasbadstuebner
Copy link

My proposed solution (even though it is not rebased) is here: #450
I would have the job be deployed in parallel on install in every case, so the wait flag does not matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init job as a helm hook
4 participants