[CRDB-49216] tests/e2e/operator: Add GCP end-to-end tests with Helm v2. #529
+1,768
−436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NishanthNalluri
requested review from
jlinder,
jmcarp,
rickystewart,
prafull01 and
pritesh-lahoti
tests/e2e/operator/singleRegion/cockroachdb_single_region_e2e_test.go
Outdated
Show resolved
Hide resolved
Comment on lines
+40
to
+58
| // CanTeardown checks if the provider supports teardown. | ||
| func CanTeardown(provider CloudProvider) (CloudProvider, bool) { | ||
| // Check if the TeardownInfra method is a no-op implementation | ||
| switch provider.(type) { | ||
| default: | ||
| return provider, true | ||
| } | ||
| } | ||
|
|
||
| // CanScale checks if the provider supports scaling. | ||
| func CanScale(provider CloudProvider) (CloudProvider, bool) { | ||
| // Check if the ScaleNodePool method is a no-op implementation | ||
| switch provider.(type) { | ||
| case *K3dRegion, *GcpRegion: | ||
| return nil, false | ||
| default: | ||
| return provider, true | ||
| } | ||
| } |
There was a problem hiding this comment.
Could these also be methods in the interface so that the respective cloud provider could implement it?
jlinder
reviewed
Jun 21, 2025
NishanthNalluri
force-pushed
the
nishanth/e2e-gcp
branch
from
14bd15b to
6d75c22
Compare
NishanthNalluri
force-pushed
the
nishanth/e2e-gcp
branch
4 times, most recently
from
6044038 to
7dc1bd8
Compare
NishanthNalluri
force-pushed
the
nishanth/e2e-gcp
branch
from
7dc1bd8 to
1153af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.