Skip to content

put ip addr for localhost (127.0.0.1) into more specific field. #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cypherfox
Copy link

For the node certificate resource, the IP address for localhost is set via the field spec.dnsNames. This seems to work in the TLS clients used within Kubernetes.
But it is not correct according to the standard. There are two separate extensions to be used for this. Cert-manager handles this by differentiating between spec.dnsNames and spec.ipAddresses.

This change simply moves the IP address "127.0.0.1" into the appropriate field.

It should not change any behaviour, only avoid potential problems with more restrictive TLS clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants