Add support for indexmap #527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Dec 27, 2023
| @@ -38,3 +39,4 @@ snapbox = "0.4.14" | |||
| [features] | |||
| default = [] | |||
| derive = ["liquid-derive"] | |||
| indexmap = ["dep:indexmap"] | |||
There was a problem hiding this comment.
Should suffix the feature with a 2 to track that this feature is for v2 (and allow us to support a v3, etc)?
epage
reviewed
Dec 27, 2023
Comment on lines
+364
to
+365
| #[cfg(feature = "indexmap")] | ||
| impl<K: ObjectIndex, V: ValueView> ValueView for IndexMap<K, V> { |
There was a problem hiding this comment.
Could you put this right after BTreeMaps impl?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility to enable the use of an
IndexMapinside of the templates. I currently use liquid in a tool of mine, where I use anIndexMapto keep elements in the order they were inserted in, as re-ordering those could lead to bugs further down.