-
Notifications
You must be signed in to change notification settings - Fork 45
Add GitHub ribbons #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add GitHub ribbons #225
Conversation
This comment has been minimized.
This comment has been minimized.
d0de705 to
d8bd319
Compare
d8bd319 to
38be83e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
38be83e to
ded0042
Compare
This comment has been minimized.
This comment has been minimized.
ded0042 to
aa6fcd9
Compare
This comment has been minimized.
This comment has been minimized.
SerekKiri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
aa6fcd9 to
370f782
Compare
|
Automated rebase with GitMate.io was successful! 🎉 |
This comment has been minimized.
This comment has been minimized.
e1f88e9 to
dd71093
Compare
This comment has been minimized.
This comment has been minimized.
dd71093 to
f019774
Compare
f019774 to
c525ea2
Compare
This comment has been minimized.
This comment has been minimized.
li-boxuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look nice 👍 Please fix the error per review https://github.com/coala/community/pull/225/files/c525ea296d950c86a3270f74b355baeec3b73781#diff-0b5ab4dd0406d0d20e8fd36568ae9821 to make CI happy :)
c525ea2 to
570c6a6
Compare
|
Done |
570c6a6 to
34dda65
Compare
li-boxuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there 👍
34dda65 to
6eff4af
Compare
li-boxuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Closes coala#24
6eff4af to
122d83b
Compare
Travis tests have failedHey @siddhpant, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: 685c3730-2c3a-11e9-b3d3-256864349aa7 |
|
Travis fails due to new version of git-url-parse being available (1.2.0) |
Closes #24.
Used http://tholman.com/github-corners/ as it's used in some other coala repos and was also suggested in the issue discussion.